Fix broken methods in LinearSerializedMagnetModel#254
Merged
gupichon merged 1 commit intoApr 24, 2026
Conversation
…eld names, misplaced attribute access). Rework compute methods to reflect physical reality: one power converter per series, compute_strengths accepts one current and returns N strengths, compute_hardware_values accepts N strengths and returns one current.
JeanLucPons
approved these changes
Apr 24, 2026
gubaidulinvadim
deleted the
253-bugfix-get_devices-broken-for-serialized-magnets
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AttributeErrorbugs inLinearSerializedMagnetModelcaused by wrong field names (powerconverters,units) and misplaced attribute access (_cfg.__sub_models)get_devices()now returns a single device;compute_strengthsaccepts one current and returns N strengths;compute_hardware_valuesaccepts N strengths and returns one currentCloses #253
Test plan
test_get_devicesverifieslen(get_devices()) == 1and that strength set/get remains consistent